-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1512-and-1504 #1516
Issue/1512-and-1504 #1516
Conversation
… guest access mode on a student made widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the idea you had here - and I hate to put some cold water on it, but I think universally flipping all instances owned by the user to guest mode is too heavy-handed. The primary reason being that if a user once again receives the author role, we don't have a method to handle the inverse, and there may be widgets previously created that were set to guest mode intentionally that could be flipped to normal mode by accident.
Rather, I'm more inclined to retain all users' instance permissions, but make features and permissions in My Widgets a little more locked down for instances that are not student-made when the user is a student.
Instances in this "grandfathered-in" mode could have the following changes, potentially:
- Attempt limits can ONLY be retained or modified to unlimited, and not any other value.
- Access can ONLY be set to Guest Mode, but the current access mode can be retained.
- Access to Student Activity is restricted (blocked)
- Access to Export Options is restricted (either blocked outright, or only Questions & Answers is available)
I think it's pretty safe to assume that for instances students already have access to but aren't student-made, the implication is that the owner was once not a student. These restrictions are pretty targeted without being overly penalizing or inconvenient. Let me know how you feel about it - I'm more than happy to go over these restrictions more in-depth or come up with an alternative.
I agree; setting all of a user's instances to guest mode could have repercussions and inverting it would be difficult. I've removed this action and updated the widget's page to do the following for once-author-now-student owners:
|
Deleting the |
Fixes #1512
Fixes #1504
Went with the option of setting all of the user's instances to guest mode, since a user whose author status has been removed having access to graded widgets feels ickyAdditional